Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base64 in JSON #1015

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Use base64 in JSON #1015

merged 4 commits into from
Jun 8, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jun 5, 2020

There are some changes in JSON representation of transaction.Witness, smartcontract.Parameter and transaction.Script in NEO3.
This PR replaces hex-encoding with base64.
https://github.com/neo-project/neo/blob/master/src/neo/Network/P2P/Payloads/Witness.cs#L47
https://github.com/neo-project/neo/blob/master/src/neo/SmartContract/ContractParameter.cs#L150

There are also changes in NEP6 token format, I won't change it now, because it is strange.

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #1015 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
- Coverage   65.57%   65.52%   -0.05%     
==========================================
  Files         188      188              
  Lines       16002    15952      -50     
==========================================
- Hits        10493    10453      -40     
+ Misses       4994     4989       -5     
+ Partials      515      510       -5     
Impacted Files Coverage Δ
pkg/core/transaction/witness.go 100.00% <ø> (+18.18%) ⬆️
pkg/rpc/response/result/contract_state.go 100.00% <ø> (+7.01%) ⬆️
pkg/core/transaction/transaction.go 78.10% <100.00%> (+1.12%) ⬆️
pkg/smartcontract/parameter.go 82.03% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd307c3...b28a8f2. Read the comment docs.

@roman-khimov
Copy link
Member

These are all good, but a rebase is needed now.

@roman-khimov roman-khimov added the rpc RPC server and client label Jun 8, 2020
@roman-khimov roman-khimov added this to the v0.90.0 milestone Jun 8, 2020
@roman-khimov roman-khimov merged commit 7afcee4 into master Jun 8, 2020
@roman-khimov roman-khimov deleted the feature/base64 branch June 8, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants