Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: treat unsolicited addr commands as errors #1562

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

roman-khimov
Copy link
Member

@roman-khimov roman-khimov added this to the v0.92.0 milestone Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1562 (2ce3c8b) into master (619b6d4) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
- Coverage   77.51%   77.49%   -0.02%     
==========================================
  Files         230      230              
  Lines       18353    18360       +7     
==========================================
+ Hits        14226    14228       +2     
- Misses       3114     3119       +5     
  Partials     1013     1013              
Impacted Files Coverage Δ
pkg/network/tcp_peer.go 29.55% <0.00%> (-0.45%) ⬇️
pkg/network/server.go 38.85% <50.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619b6d4...2ce3c8b. Read the comment docs.

@roman-khimov roman-khimov merged commit 9b7cdcc into master Nov 25, 2020
@roman-khimov roman-khimov deleted the error-on-unexpected-addr branch November 25, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants