Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce extensible payloads #1667

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Introduce extensible payloads #1667

merged 3 commits into from
Jan 22, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jan 14, 2021

Close #1663 .

Sender whitelist will be done in another PR.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1667 (b1d3ded) into master (6bc2512) will decrease coverage by 0.11%.
The diff coverage is 85.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
- Coverage   82.68%   82.56%   -0.12%     
==========================================
  Files         238      239       +1     
  Lines       19481    19540      +59     
==========================================
+ Hits        16108    16134      +26     
- Misses       2378     2402      +24     
- Partials      995     1004       +9     
Impacted Files Coverage Δ
pkg/network/message.go 95.95% <0.00%> (ø)
pkg/network/message_string.go 33.33% <42.85%> (+3.92%) ⬆️
pkg/consensus/prepare_request.go 84.61% <75.00%> (-4.28%) ⬇️
pkg/network/server.go 71.70% <76.19%> (+0.67%) ⬆️
pkg/consensus/payload.go 83.33% <77.41%> (-9.21%) ⬇️
pkg/consensus/consensus.go 71.22% <91.11%> (+3.08%) ⬆️
pkg/consensus/recovery_message.go 83.87% <100.00%> (+0.64%) ⬆️
pkg/network/payload/extensible.go 100.00% <100.00%> (ø)
pkg/network/payload/inventory.go 100.00% <100.00%> (ø)
pkg/network/metrics/metrics.go 63.63% <0.00%> (-18.19%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc2512...5d83c28. Read the comment docs.

pkg/consensus/consensus.go Show resolved Hide resolved
pkg/network/server.go Show resolved Hide resolved
@roman-khimov
Copy link
Member

roman-khimov commented Jan 21, 2021

Please merge dbft (and update its revision here) and this will be good to merge.

1. `Version` and `PrevHash` are now in `PrepareRequest`.
2. Serialization is done via `Extensible` payload.
3. Update dbft version.
@roman-khimov roman-khimov merged commit dfc23c4 into master Jan 22, 2021
@roman-khimov roman-khimov deleted the extensible branch January 22, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus dBFT consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extensible payloads and use them for consensus
2 participants