Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide additional data on deployment #1693

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Provide additional data on deployment #1693

merged 4 commits into from
Jan 29, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jan 28, 2021

Close #1682 .

Also follow neo-project/neo#2241 .

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1693 (abde16f) into master (818d598) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1693      +/-   ##
==========================================
- Coverage   82.19%   82.18%   -0.01%     
==========================================
  Files         249      248       -1     
  Lines       20169    20116      -53     
==========================================
- Hits        16577    16532      -45     
- Misses       2556     2557       +1     
+ Partials     1036     1027       -9     
Impacted Files Coverage Δ
pkg/compiler/codegen.go 90.53% <100.00%> (ø)
pkg/compiler/debug.go 92.95% <100.00%> (+0.15%) ⬆️
pkg/core/interop/context.go 95.71% <100.00%> (+1.16%) ⬆️
pkg/core/native/interop.go 62.16% <100.00%> (ø)
pkg/core/native/management.go 89.23% <100.00%> (+0.63%) ⬆️
pkg/core/native/native_neo.go 70.47% <0.00%> (-2.00%) ⬇️
pkg/core/native/policy.go 89.24% <0.00%> (-0.80%) ⬇️
pkg/core/native/notary.go 86.66% <0.00%> (-0.45%) ⬇️
pkg/network/server.go 70.49% <0.00%> (-0.41%) ⬇️
pkg/network/extpool/pool.go
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818d598...c8a07be. Read the comment docs.

pkg/core/interop/context.go Show resolved Hide resolved
cli/testdata/deploy/main.go Show resolved Hide resolved
@roman-khimov roman-khimov merged commit cb56eb4 into master Jan 29, 2021
@roman-khimov roman-khimov deleted the fix/deploy branch January 29, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement additional parameter for contract deployment
3 participants