Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: unify committee checks #1695

Merged
merged 1 commit into from
Jan 29, 2021
Merged

native: unify committee checks #1695

merged 1 commit into from
Jan 29, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jan 28, 2021

Fail execution if tx is not signed by committee.
Close #1694 .
Related #1678 (set/getprice test).

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1695 (4099901) into master (9a99054) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
+ Coverage   82.15%   82.22%   +0.07%     
==========================================
  Files         248      248              
  Lines       20080    20078       -2     
==========================================
+ Hits        16496    16509      +13     
+ Misses       2557     2543      -14     
+ Partials     1027     1026       -1     
Impacted Files Coverage Δ
pkg/core/native/management.go 88.60% <100.00%> (ø)
pkg/core/native/native_neo.go 72.46% <100.00%> (+1.99%) ⬆️
pkg/core/native/policy.go 90.03% <100.00%> (+0.79%) ⬆️
pkg/rpc/client/wsclient.go 82.70% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a99054...690b787. Read the comment docs.

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We also have setMaxNotValidBeforeDelta method for native Notary. Could you, please, fix it too?
  2. Native Management's setMinimumDeploymentFee also has the same problem, but it is not fixed in C#. I think we may leave a comment about it in C# repo.

Fail execution if tx is not signed by committee.
@fyrchik
Copy link
Contributor Author

fyrchik commented Jan 29, 2021

@AnnaShaleva (1) is fixed and setMinimumDeploymentFee was void from the start in the C# node.

@roman-khimov roman-khimov merged commit 818d598 into master Jan 29, 2021
@roman-khimov roman-khimov deleted the committeechecks branch January 29, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify committee checks in native contracts
3 participants