cli: support NEP11-related commands #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
cli/nep11
branch
3 times, most recently
from
9fe9cb8
to
f53f414
Compare
AnnaShaleva
force-pushed
the
cli/nep11
branch
3 times, most recently
from
4e2e87b
to
f5789e4
Compare
AnnaShaleva
commented
Apr 29, 2021
pkg/rpc/client/nep11.go
Outdated
| @@ -123,7 +123,7 @@ func (c *Client) TransferNEP11D(acc *wallet.Account, to util.Uint160, | |||
| if err != nil { | |||
| return util.Uint256{}, fmt.Errorf("bad account address: %w", err) | |||
| } | |||
| tx, err := c.createNEP11TransferTx(acc, tokenHash, gas, cosigners, acc.Address, from, to, amount, tokenID) | |||
| tx, err := c.createNEP11TransferTx(acc, tokenHash, gas, cosigners, from, to, amount, tokenID) | |||
There was a problem hiding this comment.
Tests are TBD in #1940.
AnnaShaleva
commented
Apr 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #1918 +/- ##
==========================================
- Coverage 82.92% 82.75% -0.17%
==========================================
Files 289 290 +1
Lines 22883 23355 +472
==========================================
+ Hits 18975 19328 +353
- Misses 2713 2797 +84
- Partials 1195 1230 +35
Continue to review full report at Codecov.
|
Four args should be specified: from, to, amount and tokenID.
It's unused.
We need to distinguish NEP11 and NEP17 tokens preesnted in the wallet.
These flags will be reused for NEP11 commands.
There's a case when cosigners are specified and data is not.
It'll be used from cli package.
Token name or hash can be used.
These are Tokens (optional), TokensOf and OwnerOf (divisible).
roman-khimov
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1860, close #1864.
TODO:
balanceandtransfer(something is wrong with transfer implementation or NFT example, investigating)