Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: add features field #1944

Merged
merged 1 commit into from
May 4, 2021
Merged

manifest: add features field #1944

merged 1 commit into from
May 4, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Apr 30, 2021

Close #1936 .

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1944 (bb039ef) into master (3acdbbd) will decrease coverage by 0.08%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1944      +/-   ##
==========================================
- Coverage   82.73%   82.65%   -0.09%     
==========================================
  Files         290      290              
  Lines       23299    23304       +5     
==========================================
- Hits        19277    19261      -16     
- Misses       2792     2801       +9     
- Partials     1230     1242      +12     
Impacted Files Coverage Δ
pkg/smartcontract/manifest/manifest.go 79.06% <60.00%> (-20.13%) ⬇️
pkg/network/server.go 70.73% <0.00%> (+0.14%) ⬆️
pkg/services/notary/notary.go 92.46% <0.00%> (+1.00%) ⬆️
pkg/services/oracle/request.go 48.92% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3acdbbd...bb039ef. Read the comment docs.

@AnnaShaleva
Copy link
Member

Has something happened with the tests?

@roman-khimov roman-khimov merged commit 0408502 into master May 4, 2021
@roman-khimov roman-khimov deleted the manifest-features branch May 4, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add features extension to manifest
3 participants