config: fix duration parameter types #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These parameters denote seconds and are thus unitless integers, not durations. Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## master #2194 +/- ##
==========================================
+ Coverage 83.72% 83.76% +0.03%
==========================================
Files 296 296
Lines 28319 28319
==========================================
+ Hits 23711 23722 +11
+ Misses 3259 3244 -15
- Partials 1349 1353 +4
Continue to review full report at Codecov.
|
roman-khimov
approved these changes
Sep 25, 2021
There was a problem hiding this comment.
Actually, I very much like time.Duration types in the configuration because they allow to specify 5s or 1m quite naturally. But we had these configurations with implicit seconds for a very long time, so it'd be painful to change them to real time.Duration, so probably this change still makes sense in the end (making current configurations valid).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters denote seconds and are thus unitless integers, not
durations. Related #2085 .
Signed-off-by: Evgeniy Stratonikov evgeniy@nspcc.ru