NEP-11 tracking #2266
Merged
NEP-11 tracking #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a lot of similarity, so try reusing common code and use more neutral naming.
Setting NewNEPXXBatch avoids the need to get them from the database which is useful for newly tracked accounts.
Make it a bit more efficient.
Makes no sense storing empty ones.
roman-khimov
force-pushed
the
nep-11-tracking
branch
from
5918033 to
b768f63
Compare
roman-khimov
force-pushed
the
nep-11-tracking
branch
from
b768f63 to
0b9ed2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
+ Coverage 84.10% 84.13% +0.02%
==========================================
Files 305 306 +1
Lines 29351 29696 +345
==========================================
+ Hits 24685 24984 +299
- Misses 3285 3299 +14
- Partials 1381 1413 +32
Continue to review full report at Codecov.
|
fyrchik
approved these changes
Nov 19, 2021
Comment on lines
+65
to
+66
| NewNEP11Batch: true, | ||
| NewNEP17Batch: true, |
There was a problem hiding this comment.
I would prefer inverted DirtyNEP11Batch flag to better handle defaults.
There was a problem hiding this comment.
Makes sense, but can be done later.
AnnaShaleva
approved these changes
Nov 19, 2021
Standards are NEP-11 and NEP-17, not NEP11, not NEP17, not anything else. Variable/function names of course can use whatever fits, but documents and comments should be consistent wrt this.
We're using proper util.Uint160 values everywhere in the client.
roman-khimov
force-pushed
the
nep-11-tracking
branch
from
0b9ed2a to
f1145c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have divisible NFTs to test it completely, but that can wait until #1940.