Store applog with tx #2305
Merged
Store applog with tx #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit longer script easily solves the size problem.
roman-khimov
force-pushed
the
store-applog-with-tx
branch
2 times, most recently
from
d083162
to
0fd95e1
Compare
AnnaShaleva
reviewed
Dec 9, 2021
Two times less keys inserted into the DB per tx leads to ~13% TPS improvement. We also drop one goroutine with it which isn't bad as well.
roman-khimov
force-pushed
the
store-applog-with-tx
branch
from
0fd95e1
to
4c39b66
Compare
Codecov Report
@@ Coverage Diff @@
## master #2305 +/- ##
========================================
Coverage 84.04% 84.05%
========================================
Files 306 306
Lines 29775 29906 +131
========================================
+ Hits 25025 25136 +111
- Misses 3330 3333 +3
- Partials 1420 1437 +17
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're a bit slow.
Solution
Increase da TPS.
It will interfere with #2299, so we can wait for a while before merging it, maybe improve some naming or things along the way (for example, RPC server can now technically get both tx and aer for
getrawtransactionrequest in a single query, but I'm not sure it's worth doing this, there are no other similar simultaneous uses).