core: remove contract script check on deploy/update #3052
Conversation
This check is good and was present here since #1729, but it was accidently removed from the reference implementation (see the discussion in neo-project/neo#2848). The removal of this check from the C# node leaded to the T5 testnet state diff since 1670095 heigh which causes inability to process new blocks since 2272533 height (see #3049). This check was added back to the C# node in neo-project/neo#2849, but it is planned to be the part of the upcoming 3.6.0 C# node release. We need to keep our testnet healthy, thus, strict contract script check will be temporary removed from the node code and is planned to be added back to be a part of the next 3.6.0-compatible release. Close #3049. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
remove-script-check
branch
from
e3d560d
to
6fa4bcd
Compare
|
@roman-khimov, since we need our T5 machine in a proper working state and we don't know when 3.6.0 is going to happen, I'd suggest to release yet another 3.5.0-compatible release with this fix. After 3.6.0 is released, we'll revert these changes and create 0.102.0. This fix is compatible with mainnet up to 3712135 and with testnet up to 2294980. |
Slightly hijacking here; but if you do create another compatible 3.5.0 release, can you please include #3014 in that as well ? 🙏 |
To be honest, I hope that we'll see v3.6.0 within a couple of weeks (hi, neo-project/neo#2844 (comment)) and then it won't be necessary to release 0.101.3, we'll release 0.102.0 instead (which includes #3014). But if not, then I think it's OK to include #3014 into 0.101.3 as far, it's compatible improvement. |
|
Let's convet it to draft, we'll wait until 3.6 is released, no need to hurry. |
@ixje, back to your request: I apologize for the misinformation, but we've released https://github.com/nspcc-dev/neo-go/releases/tag/v0.101.3 without #3014, because it's kind of "dirty" release that contains only a single T5 incompatibility fix. We've discussed the 3.6 release date with Steven and Owen, it's scheduled for the next week, so we have to wait a little bit more. #3014 is too good to be included into v0.101.3. |
This check is good and was present here since #1729, but it was accidently removed from the reference implementation (see the discussion in neo-project/neo#2848). The removal of this check from the C# node leaded to the T5 testnet state diff since 1670095 heigh which causes inability to process new blocks since 2272533 height (see #3049). This check was added back to the C# node in neo-project/neo#2849, but it is planned to be the part of the upcoming 3.6.0 C# node release.
We need to keep our testnet healthy, thus, strict contract script check will be temporary removed from the node code and is planned to be added back to be a part of the next 3.6.0-compatible release.
Close #3049.