Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go-ordered-json version #3286

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Upgrade go-ordered-json version #3286

merged 2 commits into from
Jan 12, 2024

Conversation

AliceInHunterland
Copy link
Contributor

@AliceInHunterland AliceInHunterland commented Jan 10, 2024 •
edited
Loading 

ekaterina@ekaterina-ThinkPad-T14-Gen-1:~/Desktop/neo-go$ go run scripts/compare-states/compare-states.go http://localhost:10332 http://seed1.neo.org:10332 
at 0: 58a5157b7e99eeabf631291f1747ec8eb12ab89461cda888492b17a301de81e8 vs 58a5157b7e99eeabf631291f1747ec8eb12ab89461cda888492b17a301de81e8
at 4716143: a64d3eaec83ab6c45f34136bcb4473d0f12821c283440f297e2c69fdc1d78886 vs a64d3eaec83ab6c45f34136bcb4473d0f12821c283440f297e2c69fdc1d78886

ekt@ekt:~/neo-go$ go run ./scripts/compare-states/compare-states.go http://localhost:20332 http://seed1t5.neo.org:20332
at 0: 62fd8ff9b0543aea352257db5b00bbb01d1bc0d2cc665e1f24cf5de0d16ebc7b vs 62fd8ff9b0543aea352257db5b00bbb01d1bc0d2cc665e1f24cf5de0d16ebc7b
at 3320969: 7cbac469505835bd8d9c6a5bc84172d4234b0d04235b936ee3f391bff6120e29 vs 7cbac469505835bd8d9c6a5bc84172d4234b0d04235b936ee3f391bff6120e29

Closes #3284

AnnaShaleva
AnnaShaleva reviewed Jan 11, 2024
View reviewed changes
pkg/smartcontract/manifest/manifest_test.go Outdated Show resolved Hide resolved
pkg/smartcontract/manifest/manifest_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@AnnaShaleva
Copy link
Member

Include testnet state comparison data to PR description, please.

@AliceInHunterland
*: upgrade go-ordered-json version
188a5e6 
Ref. nspcc-dev/go-ordered-json/pull/9 needed for C# double quotes
marshalling compatibility.

Closes #3284

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland
smartcontract: add test of extraToStackItem with double quotes
baac738 
C# double quotes marshalling compatibility test.

Refs #3284

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland marked this pull request as ready for review January 12, 2024 08:22
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d901697) 85.14% compared to head (baac738) 85.21%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3286      +/-   ##
==========================================
+ Coverage   85.14%   85.21%   +0.07%     
==========================================
  Files         327      327              
  Lines       44437    44437              
==========================================
+ Hits        37836    37868      +32     
+ Misses       5098     5063      -35     
- Partials     1503     1506       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnnaShaleva AnnaShaleva changed the title upgrade go-ordered-json version Upgrade go-ordered-json version Jan 12, 2024
@AnnaShaleva AnnaShaleva merged commit 32fab1a into master Jan 12, 2024
17 of 19 checks passed
@AnnaShaleva AnnaShaleva deleted the quotes branch January 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mainnet state diff around 4688K
2 participants
@AliceInHunterland @AnnaShaleva