Adjust expected unclaimed GAS calculation for TestNEO_CalculateBonus #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
The behaviour is the same, the result is also the same, but the meaning is fixed. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3596 +/- ##
=======================================
Coverage 85.26% 85.26%
=======================================
Files 333 333
Lines 39005 39005
=======================================
Hits 33256 33256
+ Misses 4177 4176 -1
- Partials 1572 1573 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Oct 4, 2024
|
@AliceInHunterland, please ensure you understand reward calculations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Misleading expected unclaimed GAS calculation record in test.
Solution
Fix it, add some comments.