Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: fix modmul operation #3599

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

Slava0135
Copy link
Contributor

Problem

Resolves #3598

Solution

Use Rem operation instead of Mod, same as in MOD opcode

Signed-off-by: Slava0135 <super.novalskiy_0135@inbox.ru>
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (fb4a4f0) to head (9aca090).
Report is 311 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3599      +/-   ##
==========================================
- Coverage   86.10%   85.19%   -0.92%     
==========================================
  Files         331      333       +2     
  Lines       38107    39007     +900     
==========================================
+ Hits        32813    33231     +418     
- Misses       3780     4206     +426     
- Partials     1514     1570      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it shouldn't be a Euclidian division, a really nice catch!

@AnnaShaleva AnnaShaleva merged commit 1115193 into nspcc-dev:master Oct 7, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modmul operation returns wrong results for negative numbers
2 participants