Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify decoding compressed Y #447

Closed
wants to merge 1 commit into from

Conversation

im-kulikov
Copy link
Contributor

Step by step ops with comments

@im-kulikov im-kulikov self-assigned this Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #447 into master will increase coverage by 0.02%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   48.22%   48.25%   +0.02%     
==========================================
  Files         103      103              
  Lines        7861     7859       -2     
==========================================
+ Hits         3791     3792       +1     
+ Misses       3764     3759       -5     
- Partials      306      308       +2
Impacted Files Coverage Δ
pkg/crypto/keys/publickey.go 53.67% <90%> (-1.4%) ⬇️
pkg/core/blockchain.go 36.71% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcf092...07c08f9. Read the comment docs.

pkg/crypto/keys/publickey.go Outdated Show resolved Hide resolved
pkg/crypto/keys/publickey.go Outdated Show resolved Hide resolved
pkg/crypto/keys/publickey.go Outdated Show resolved Hide resolved
@roman-khimov
Copy link
Member

I don't see how it improves anything, really. Adding comments would probably help, but rewriting it this way? Also, this code works and probably won't be touched for years, it's a very minor technical detail. Chances are it's even gonna be moved into golang itself: golang/go#34105.

Step by step ops with comments
@im-kulikov im-kulikov force-pushed the simplify_decoding_compressed_y branch from 9e03989 to 07c08f9 Compare October 23, 2019 10:15
@im-kulikov
Copy link
Contributor Author

@roman-khimov I just replace code with code taken from stdlib, it's more clearly to understand IMHO

@roman-khimov
Copy link
Member

I don't see much interest in this change and it's not obvious whether it improves anything, so I'm closing it.

@im-kulikov im-kulikov deleted the simplify_decoding_compressed_y branch November 5, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants