Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netmap: Support protocol changes related to NetworkInfo #339

Merged
merged 1 commit into from
Sep 29, 2021
Merged

netmap: Support protocol changes related to NetworkInfo #339

merged 1 commit into from
Sep 29, 2021

Conversation

cthulhu-rider
Copy link
Contributor

No description provided.

@cthulhu-rider cthulhu-rider marked this pull request as draft September 16, 2021 13:18
@codecov
Copy link

codecov bot commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #339 (7d1b25f) into master (520a065) will increase coverage by 0.16%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   62.82%   62.98%   +0.16%     
==========================================
  Files         120      120              
  Lines       13904    14110     +206     
==========================================
+ Hits         8735     8887     +152     
- Misses       4177     4216      +39     
- Partials      992     1007      +15
Impacted Files Coverage Δ
pkg/version.go 90.00% <ø> (ø)
v2/netmap/types.go 36.86% <37.50%> (+0.10%) ⬆️
v2/netmap/marshal.go 64.24% <60.00%> (-0.93%) ⬇️
v2/netmap/convert.go 77.72% <87.93%> (+1.58%) ⬆️
pkg/netmap/network_info.go 97.70% <100.00%> (+3.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520a065...7d1b25f. Read the comment docs.

@cthulhu-rider cthulhu-rider force-pushed the feature/netinfo-expand branch 2 times, most recently from 0a03920 to bb8e626 Compare September 20, 2021 12:03
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this pull request Sep 28, 2021
[nspcc-dev#339] netmap: Support protocol changes related to NetworkInfo
2d94eed 
Recompile NeoFS API protobuf files. Implement `NetworkParameter` and
`NetworkConfig` types. Expand `NetworkInfo` type with MillisecondsPerBlock
and `NetworkConfig`.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review September 28, 2021 08:11
@alexvanin
Copy link
Contributor

Is it possible to update to the latest protobuf to the latest version as well, as soon as we recompile everything there?
https://github.com/protocolbuffers/protobuf/releases/tag/v3.18.0

@cthulhu-rider
Copy link
Contributor Author

Is it possible to update to the latest protobuf to the latest version as well, as soon as we recompile everything there? https://github.com/protocolbuffers/protobuf/releases/tag/v3.18.0

I'd merge #344 before.

alexvanin
alexvanin previously approved these changes Sep 28, 2021
View reviewed changes
@alexvanin
Copy link
Contributor

Is it possible to update to the latest protobuf to the latest version as well, as soon as we recompile everything there? https://github.com/protocolbuffers/protobuf/releases/tag/v3.18.0

I'd merge #344 before.

Sorry, I meant to leave this comment in #344, not this PR.

@alexvanin alexvanin mentioned this pull request Sep 28, 2021
Merged
[nspcc-dev#339] netmap: Support protocol changes related to NetworkInfo
7d1b25f 
Recompile NeoFS API protobuf files. Implement `NetworkParameter` and
`NetworkConfig` types. Expand `NetworkInfo` type with MillisecondsPerBlock
and `NetworkConfig`.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@alexvanin alexvanin merged commit 010b1b0 into nspcc-dev:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvanin alexvanin alexvanin approved these changes

@carpawell carpawell Awaiting requested review from carpawell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
2 participants
@cthulhu-rider @alexvanin