Prevent potential NPE in NEO3WalletFromPublicKey #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy `Curve` field of `ecdsa.PublicKey` arg to `keys.PublicKey` instance in `NEO3WalletFromPublicKey` function. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
bugfix/wallet-parsing
branch
from
5d0412e
to
881a13f
Compare
alexvanin
approved these changes
Sep 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=======================================
Coverage 63.05% 63.06%
=======================================
Files 119 119
Lines 13844 13845 +1
=======================================
+ Hits 8730 8731 +1
Misses 4122 4122
Partials 992 992
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was detected after local updating of neo-go library which started to use
Curvefield inPublicKey.Addressmethod.