Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Response info callback #342

Merged
merged 2 commits into from
Sep 28, 2021
Merged

client: Response info callback #342

merged 2 commits into from
Sep 28, 2021

Conversation

cthulhu-rider
Copy link
Contributor

Closes #337.

@cthulhu-rider cthulhu-rider added bug Something isn't working enhancement Improving existing functionality labels Sep 27, 2021
@cthulhu-rider cthulhu-rider self-assigned this Sep 27, 2021
@cthulhu-rider cthulhu-rider marked this pull request as draft September 27, 2021 11:44
@codecov
Copy link

codecov bot commented Sep 27, 2021 •
edited
Loading

Codecov Report

Merging #342 (f7b9d44) into master (e887368) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

❗ Current head f7b9d44 differs from pull request most recent head e88b6ab. Consider uploading reports for the commit e88b6ab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   63.06%   62.83%   -0.24%     
==========================================
  Files         119      120       +1     
  Lines       13845    13896      +51     
==========================================
  Hits         8731     8731              
- Misses       4122     4173      +51     
  Partials      992      992
Impacted Files Coverage Δ
pkg/client/accounting.go 0.00% <0.00%> (ø)
pkg/client/container.go 0.00% <0.00%> (ø)
pkg/client/netmap.go 0.00% <0.00%> (ø)
pkg/client/object.go 2.32% <0.00%> (-0.06%) ⬇️
pkg/client/opts.go 0.00% <ø> (ø)
pkg/client/reputation.go 0.00% <0.00%> (ø)
pkg/client/response.go 0.00% <0.00%> (ø)
pkg/client/session.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e887368...e88b6ab. Read the comment docs.

Leonard Lyubich added 2 commits September 28, 2021 11:12
[nspcc-dev#342] v2/reputation: Fix incorrect return of AnnounceInterm…
082cef6 
…ediateResult

Return `AnnounceIntermediateResultResponse` instead of
`AnnounceIntermediateResultRequest` from `rpc.AnnounceIntermediateResult`.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
[nspcc-dev#337] client: Add option to specify callback of response in…
e88b6ab 
…formation

There is a need to analyze some response information in API client.

Define `ResponseMetaInfo` structure of response information. Add
`WithResponseInfoHandler` client option which allows to set the response
info callback. The callback is called right after any response is received.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review September 28, 2021 08:13
@alexvanin alexvanin merged commit da89c2b into nspcc-dev:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvanin alexvanin alexvanin approved these changes

@carpawell carpawell Awaiting requested review from carpawell

Assignees

@cthulhu-rider cthulhu-rider

Labels
bug Something isn't working enhancement Improving existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch signer info from client response
2 participants
@cthulhu-rider @alexvanin