Feat/Support signature status #405
Conversation
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
- Coverage 63.88% 63.84% -0.05%
==========================================
Files 75 75
Lines 9182 9182
==========================================
- Hits 5866 5862 -4
- Misses 2612 2614 +2
- Partials 704 706 +2
Continue to review full report at Codecov.
|
util/signature/options.go
Outdated
| // ErrUnsupportedSignatureScheme is returned when | ||
| // the library does not support a signature scheme | ||
| // that was used for signing a data. | ||
| type ErrUnsupportedSignatureScheme struct { | ||
| scheme refs.SignatureScheme |
There was a problem hiding this comment.
How is it related to this commit?
There was a problem hiding this comment.
PR adds supporting signature status code and adds some functionality that allows api-go callers to understand what exactly error happened (to use the new status code)
or do you just mean to put that to a separate commit?
please, see the node PR decs before merging that PR
There was a problem hiding this comment.
I think we should either create a separate API status or continue using a string message with all wrapping context.
This type just adds another level of abstraction, api-go should be small and reflect API as much as possible.
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Related to nspcc-dev/neofs-api#200.