Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deprecated elements #417

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

cthulhu-rider
Copy link
Contributor

No description provided.

@cthulhu-rider cthulhu-rider self-assigned this Sep 17, 2022
Leonard Lyubich added 2 commits September 17, 2022 10:46
`expiration_epoch` field of `StorageGroup` message has been marked as
deprecated in previous NeoFS API protocol's release.

Mark all method related to the field as deprecated. Leave and use them
for test purposes only.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
`grpc.WithInsecure` has been marked as deprecated in earlier releases of
`google.golang.org/grpc`.

Use `google.golang.org/grpc/credentials/insecure` package instead as
recommended.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #417 (065643e) into master (f3e1f8a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   64.02%   64.00%   -0.02%     
==========================================
  Files          75       75              
  Lines        9186     9185       -1     
==========================================
- Hits         5881     5879       -2     
- Misses       2601     2602       +1     
  Partials      704      704              
Impacted Files Coverage Δ
rpc/client/connect.go 36.84% <0.00%> (+0.94%) ⬆️
storagegroup/convert.go 68.96% <ø> (ø)
storagegroup/types.go 33.33% <ø> (ø)
object/marshal.go 74.35% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cthulhu-rider cthulhu-rider merged commit 504e427 into nspcc-dev:master Sep 23, 2022
cthulhu-rider pushed a commit that referenced this pull request Sep 23, 2022
`expiration_epoch` field of `StorageGroup` message has been marked as
deprecated in previous NeoFS API protocol's release.

Mark all method related to the field as deprecated. Leave and use them
for test purposes only.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants