Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netmap: Support NetmapService.NetmapSnapshot RPC #418

Merged

Conversation

cthulhu-rider
Copy link
Contributor

No description provided.

@cthulhu-rider cthulhu-rider self-assigned this Sep 17, 2022
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #418 (845c140) into master (f3e1f8a) will decrease coverage by 0.09%.
The diff coverage is 56.09%.

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   64.02%   63.92%   -0.10%     
==========================================
  Files          75       75              
  Lines        9186     9350     +164     
==========================================
+ Hits         5881     5977      +96     
- Misses       2601     2658      +57     
- Partials      704      715      +11     
Impacted Files Coverage Δ
netmap/marshal.go 66.14% <0.00%> (-8.86%) ⬇️
signature/sign.go 41.12% <0.00%> (-0.79%) ⬇️
netmap/types.go 32.72% <33.33%> (+0.07%) ⬆️
netmap/convert.go 77.37% <82.00%> (+1.08%) ⬆️
object/marshal.go 75.45% <0.00%> (+0.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this pull request Sep 19, 2022
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review September 19, 2022 07:43
fyrchik
fyrchik previously approved these changes Sep 19, 2022
rpc/netmap.go Outdated Show resolved Hide resolved
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider merged commit cf86818 into nspcc-dev:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants