rpc/client: Use dial timeout properly #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous implementation `Client` didn't block until the connection is up on dial stage. This caused the dial timeout to have no effect. Provide `WithBlock` dial option to `DialContext` call in `openGRPCConn` method. From now `Client` blocks for configured timeout until the connection is up. Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider
added a commit
to cthulhu-rider/neofs-api-go
that referenced
this pull request
Oct 3, 2022
In previous implementation `Client` passed `context.Background()` to `grpc.DialContext` function. This didn't allow to abort dial stage by the given context. Base dial context on the one provided with `WithContext` option. Fall back to using `context.Background` if context is not specified. Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider
force-pushed
the
bugfix/rpc-client-dial-timeout
branch
from
4563c7f
to
3bdb3a4
Compare
cthulhu-rider
requested review from
acid-ant,
alexvanin,
carpawell and
fyrchik
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
- Coverage 63.75% 63.21% -0.54%
==========================================
Files 75 75
Lines 9349 9355 +6
==========================================
- Hits 5960 5914 -46
- Misses 2671 2729 +58
+ Partials 718 712 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
BTW, you may want to enable |
carpawell
previously approved these changes
Oct 4, 2022
fyrchik
previously approved these changes
Oct 4, 2022
rpc/client/connect.go
Outdated
| cancel() | ||
| if err != nil { | ||
| return fmt.Errorf("open gRPC client connection: %w", err) |
There was a problem hiding this comment.
The function is called open, may be it is better to wrap on the caller side?
rpc/client/call_options.go
Outdated
| return &callParameters{ | ||
| callOpts: make([]grpc.CallOption, 0, 1), | ||
| } | ||
| return &callParameters{} |
There was a problem hiding this comment.
Use context.Background as default?
In previous implementation `Client` passed `context.Background()` to `grpc.DialContext` function. This didn't allow to abort dial stage by the given context. Base dial context on the one provided with `WithContext` option. Fall back to using `context.Background` if context is not specified. Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider
force-pushed
the
bugfix/rpc-client-dial-timeout
branch
from
3bdb3a4
to
62298db
Compare
alexvanin
approved these changes
Oct 4, 2022
carpawell
approved these changes
Oct 4, 2022
cthulhu-rider
added a commit
that referenced
this pull request
Oct 5, 2022
In previous implementation `Client` didn't block until the connection is up on dial stage. This caused the dial timeout to have no effect. Provide `WithBlock` dial option to `DialContext` call in `openGRPCConn` method. From now `Client` blocks for configured timeout until the connection is up. Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.