Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature response for initial replication #299

Closed
roman-khimov opened this issue Jun 27, 2024 · 1 comment
Closed

Signature response for initial replication #299

roman-khimov opened this issue Jun 27, 2024 · 1 comment
Assignees
@carpawell
Labels
feature Completely new functionality I2 Regular impact S2 Regular significance U2 Seriously planned

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we can't prove the object was accepted by an appropriate number of nodes. After nspcc-dev/neofs-node#2802 we'll be using replication API exclusively for inter-node communication, so we can extend it a bit more.

Describe the solution you'd like

Extend request with an optional "create" flag, add an optional response field for a single signature.

Describe alternatives you've considered

Sending signatures independently notary-style. Adds additional delay and complexity. Here we directly interact with all parties, so an object entry node can collect all the data easily.
@roman-khimov roman-khimov added U2 Seriously planned S2 Regular significance I2 Regular impact feature Completely new functionality labels Jun 27, 2024
@roman-khimov
Copy link
Member Author

It can be generalized to []byte response field.

This was referenced Jun 27, 2024
Closed
Closed
Open
Open
carpawell added a commit that referenced this issue Jul 5, 2024
@carpawell
object/replicate: Add signature to the replication RPC
7f0744e 
Object signing now may be requested to ensure a replication copy was received.
Closes #299.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell mentioned this issue Jul 5, 2024
Merged
carpawell added a commit that referenced this issue Jul 5, 2024
@carpawell
object/replicate: Add signature to the replication RPC
5d167b1 
Object signing now may be requested to ensure a replication copy was received.
Closes #299.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Jul 25, 2024
@carpawell
object/replicate: Add signature to the replication RPC
a5de2ef 
Object signing now may be requested to ensure a replication copy was received.
Closes #299.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to nspcc-dev/neofs-node that referenced this issue Sep 6, 2024
@carpawell
node/object/put: exchange meta signatures during replication
a30127e 
Initial replication requires nodes to sign object's main meta information and
respond with it. Meta information is not sent on wire and treated as a fixed
ordered NEO's map. Signatures are verified, not stored/send anywhere yet.
It follows recent API extension: nspcc-dev/neofs-api#299.
Closes #2876.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to nspcc-dev/neofs-node that referenced this issue Sep 6, 2024
@carpawell
node/object/put: exchange meta signatures during replication
c13f5f4 
Initial replication requires nodes to sign object's main meta information and
respond with it. Meta information is not sent on wire and treated as a fixed
ordered NEO's map. Signatures are verified, not stored/send anywhere yet.
It follows the recent API extension: nspcc-dev/neofs-api#299.
Further, this extension is planned to have a contract adoption:
nspcc-dev/neofs-contract#413 and nspcc-dev/neofs-contract#414.
Closes #2876.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to nspcc-dev/neofs-node that referenced this issue Sep 10, 2024
@carpawell
node/object/put: exchange meta signatures during replication
e63289a 
Initial replication requires nodes to sign object's main meta information and
respond with it. Meta information is not sent on wire and treated as a fixed
ordered NEO's map. Signatures are verified, not stored/send anywhere yet.
It follows the recent API extension: nspcc-dev/neofs-api#299.
Further, this extension is planned to have a contract adoption:
nspcc-dev/neofs-contract#413 and nspcc-dev/neofs-contract#414.
Closes #2876.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to nspcc-dev/neofs-node that referenced this issue Sep 10, 2024
@carpawell
node/object/put: exchange meta signatures during replication
b724d14 
Initial replication requires nodes to sign object's main meta information and
respond with it. Meta information is not sent on wire and treated as a fixed
ordered NEO's map. Signatures are verified, not stored/send anywhere yet.
It follows the recent API extension: nspcc-dev/neofs-api#299.
Further, this extension is planned to have a contract adoption:
nspcc-dev/neofs-contract#413 and nspcc-dev/neofs-contract#414.
Closes #2876.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
feature Completely new functionality I2 Regular impact S2 Regular significance U2 Seriously planned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman-khimov @carpawell