object: Support numerical search queries #285
Conversation
cthulhu-rider
requested review from
carpawell and
roman-khimov
as code owners
cthulhu-rider
force-pushed
the
feature/265-search-match-num
branch
from
63b99c2
to
3aa02e1
Compare
| NUM_LT = 7; | ||
|
|
||
| // Numerical 'less or equal than' | ||
| NUM_LE = 8; |
There was a problem hiding this comment.
NUM_EQUAL?
the previously added STRING_EQUAL / STRING_NOT_EQUAL matchers are suitable for numerical == / !=.
While it is true for now, it looks strange to me. Users should use STRING_EQUAL for numbers in their interfaces. Also, it is possible not to have strings-only values in the future.
There was a problem hiding this comment.
new values will be added when the existing ones are no longer sufficient
There was a problem hiding this comment.
I had this question as well, but as we're not supporting different notations ("1e8", for example) now, current set is sufficient for the purpose.
There was a problem hiding this comment.
my main point, i would say, in the naming of this message: MatchType (it is not bound to Filter), no info about what it relates to. i can imagine reusing this for a number representation of smth, then we will have to add NUM_EQUAL but we will already have had some users that will be using STRING_EQUAL, strange
There was a problem hiding this comment.
this enum is not intended to be reused. Imaginary importer will have to use it as it is, or will define it's own enum. Anyway, these are just numbers. Protocol inflation for the indefinite future is bad thing to do imo
There was a problem hiding this comment.
this enum is not intended to be reused
but there are no words about what it is used for
cthulhu-rider
dismissed stale reviews from carpawell and roman-khimov
via
37645b7
cthulhu-rider
force-pushed
the
feature/265-search-match-num
branch
from
3aa02e1
to
37645b7
Compare
|
rebased and CHANGELOGed |
Previously, protocol did not support numerical search queries for objects. This may be needed for system attributes such as payload size or creation epoch, and for user ones if required by the client application. New values of `MatchType` enumeration are added: `>`, `>=`, `<`, `<=`. These attributes allow user to search for objects with any decimal attributes. While only base-10 numbers are allowed, additional bases may be supported in the future without new enumerations Note that the previously added `STRING_EQUAL` / `STRING_NOT_EQUAL` matchers are suitable for numerical `==` / `!=`. Closes #265. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
feature/265-search-match-num
branch
from
37645b7
to
0588aca
Compare
Previously, protocol did not support numerical search queries for objects. This may be needed for system attributes such as payload size or creation epoch, and for user ones if required by the client application.
New values of
MatchTypeenumeration are added:>,>=,<,<=. These attributes allow user to search for objects with any decimal attributes. While only base-10 numbers are allowed, additional bases may be supported in the future without new enumerationsNote that the previously added
STRING_EQUAL/STRING_NOT_EQUALmatchers are suitable for numerical==/!=.Closes #265.