-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acl: Extend BearerToken
message with issuer
field
#292
Conversation
Previously, `BearerToken` message had no explicit field for the token issuer. This could become a limitation on subject identification because only public key derivation was supported. To prevent this, `issuer` field is added. Closes #266. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it solve? It can be trusted only if we trust the signature (know key/signature -> container owner (and only the owner as it is said in this PR) relation).
@carpawell problem is mentioned in the commit
|
If it's present we can fetch additional data from contracts or in any other way, we can check public key corresponds to it. The way I see it now is we basically have two ways to solve ID (user) issues:
This makes the first option easier. |
No validation -- GW may consider any issuer, the issuer is not proofed.
The same way public key can be sent to a contract to get owner? |
That's different to me. ID is more abstract than a key, it doesn't imply any specific validation scheme on its own. |
dont see any problem with this. GW is GW, it just transmits data back and forth b/w protocols. Self validation is not really good behavior for such entity |
No description provided.