Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contract constants be properly available #402

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Conversation

roman-khimov
Copy link
Member

This allows to not import contracts into other code, RPC bindings are sufficient. Fixes #371.

cthulhu-rider
cthulhu-rider previously approved these changes Jun 17, 2024
contracts/netmap/contract.go Outdated Show resolved Hide resolved
cthulhu-rider
cthulhu-rider previously approved these changes Jun 17, 2024
Refs. #371.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Which allows to use binding only with its types for all current purposes.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Make them easily reusable, no functional changes. Refs. #371.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Make them easier to use.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
No functional changes.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
It was merged earlier.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
Copy link
Member Author

Rebased after #403 merge.

@roman-khimov roman-khimov merged commit 493eb8d into master Jun 18, 2024
10 checks passed
@roman-khimov roman-khimov deleted the rpc-constants branch June 18, 2024 08:19
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NNS constants micropackage
3 participants