This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Use consistent parameter names for Sign and Verify functions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrchik
reviewed
Nov 12, 2019
| // panic("could not unmarshal r / s") | ||
| // Verify verifies the signature of msg using the public key pub. It returns | ||
| // nil only if signature is valid. | ||
| func Verify(pub *ecdsa.PublicKey, sig, msg []byte) error { |
There was a problem hiding this comment.
I think it is better also to also change order of msg and sig, because go's stdlib and many other libraries (e.g. kyber) accept first message then signature.
https://golang.org/pkg/crypto/ed25519/#Verify
https://golang.org/pkg/crypto/ecdsa/#Verify
https://golang.org/pkg/crypto/rsa/#VerifyPKCS1v15
There was a problem hiding this comment.
I thought about it, but decided to make small changes at first.
Let's see @im-kulikov review. If the general idea of this PR is okay, I don't mind to change the order of parameters for better consistency.
im-kulikov
reviewed
Nov 12, 2019
It may be misleading when verify function takes signature as a hash parameter. This commit suggested to use rfc6979 original naming for the parameters: - `msg` as the message to sign, - `sig` as the signature of message. All hashing operations are encapsulated inside of the Sign and Verify functions. Also there are comment fixes and re-usage of `hashBytes()` in rfc6979.
fyrchik
approved these changes
Nov 12, 2019
im-kulikov
approved these changes
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be misleading when verify function takes signature as a hash
parameter. This commit suggested to use rfc6979 original naming
for the parameters:
msgas the message to sign,sigas the signature of message.All hashing operations are encapsulated inside of the Sign
and Verify functions.
Also there are comment fixes and re-usage of
hashBytes()in rfc6979.