Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to ignore uninited shards #2471

Closed
roman-khimov opened this issue Aug 4, 2023 · 0 comments · Fixed by #2953
Closed

Option to ignore uninited shards #2471

roman-khimov opened this issue Aug 4, 2023 · 0 comments · Fixed by #2953
Assignees
@End-rey
Labels
enhancement Improving existing functionality good first issue Good for newcomers I3 Minimal impact neofs-storage Storage node application issues S4 Routine U2 Seriously planned
Milestone
v0.44.0

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

#2464 changed the default behavior to more sane one, but we need an option to override it in special cases (like recovery or something).

Describe the solution you'd like

CLI/env/config option like --ignore-missing-shards.
@roman-khimov roman-khimov added enhancement Improving existing functionality good first issue Good for newcomers neofs-storage Storage node application issues labels Aug 4, 2023
@roman-khimov roman-khimov added U2 Seriously planned S4 Routine I3 Minimal impact labels Dec 21, 2023
@roman-khimov roman-khimov mentioned this issue Dec 21, 2023
Closed
@roman-khimov roman-khimov added this to the v0.44.0 milestone Sep 24, 2024
End-rey added a commit that referenced this issue Sep 27, 2024
@End-rey
engine: add flag to ignore missing shards
6156a4e 
Add config bool option `storage.ignore_missing_shards` which specifies whether
missing shards should be ignored. If option is set to `false`, then immediately
fail engine's `Open`/`Init` methods on any shard failure, otherwise continue
working.

Closes #2471.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
@End-rey End-rey mentioned this issue Sep 27, 2024
Merged
End-rey added a commit that referenced this issue Sep 30, 2024
@End-rey
engine: add flag to ignore uninited shards
a663221 
Add config bool option `storage.ignore_uninited_shards` which specifies whether
uninited shards should be ignored. If option is set to `false`, then immediately
fail engine's `Open`/`Init` methods on any shard failure, otherwise continue
working.

Closes #2471.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
roman-khimov added a commit that referenced this issue Sep 30, 2024
@roman-khimov
engine: option to ignore uninited shards (#2953)
56d532b 
Closes #2471.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@End-rey End-rey

Labels
enhancement Improving existing functionality good first issue Good for newcomers I3 Minimal impact neofs-storage Storage node application issues S4 Routine U2 Seriously planned
Projects
None yet
Milestone
v0.44.0
Development

Successfully merging a pull request may close this issue.

engine: option to ignore uninited shards nspcc-dev/neofs-node
2 participants
@roman-khimov @End-rey