Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple addresses #607

Closed
4 tasks
alexvanin opened this issue Jun 11, 2021 · 2 comments · Fixed by #628
Closed
4 tasks

Support multiple addresses #607

alexvanin opened this issue Jun 11, 2021 · 2 comments · Fixed by #628
Assignees
@cthulhu-rider
Labels
neofs-storage Storage node application issues

Comments

@alexvanin
Copy link
Contributor

Related nspcc-dev/neofs-api#160

  • Multiple NODE_ADDRESS and GRPC_ENDOINT addresses should be supported in config.
  • Run node on all provided gRPC endpoints.
  • Announce all provided node addresses.
  • Iterate over sorted* list of endpoints in client cache until you establish connection.
  • Sorted list is a list with all TLS endpoints before others.
@cthulhu-rider cthulhu-rider self-assigned this Jun 16, 2021
@cthulhu-rider
Copy link
Contributor

We need to recognize Client's connection failures. I can suggest two approaches.

1. Dedicated Open or Init method

Before any RPC caller should call the method to establish the connection. In this approach we need to think about how Client behaves if connection was provided to constructor (e.g. check status). Any RPC should once do pre-opening in order to save previous behavior.

2. Dedicated connection errors

Define typed error which can be returned from any RPC method. Check the error when we iterate over all per-address Clients.

As for me, 2 is clearer, but 1 also has a place to be.

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Don't export L4 protocol constant
ecdeb1b 
Const is used for internal package needs only.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Use Equal method in IsLocalAddress function
4a3e2a0 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Prevent potential panic in Address.Equal m…
86d2c30 
…ethod

Make `Address.Equal` method to accept value instead of pointer in order to
prevent NPE.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Accept value instead of pointer in IsLocalAd…
5fbdd53 
…dress

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Remove unused HostAddrFromMultiaddr function.
0ffe6ea 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Reflect all supported formats in AddressFrom…
2859c7d 
…String docs

Comment that `AddressFromString` function supports host addresses.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Do not return error from `Address.HostAddrSt…
33ec3b9 
…ring` method

Panic if internal `manet.DialArgs` call returns error since this is
unexpected according to `AddressFromString` implementation.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Rename Address.HostAddrString method to Host…
9a453c5 
…Addr

Return tyype is clear from the method's signature and docs, there is no
point in reflecting it in the name.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Remove Address methods used only for testing
4bcf29a 
Remove `Encapsulate`, `Decapsulate` and `IPAddrString` methods of `Address`
since they are used in unit tests only.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Do not use Address.String for address compar…
a54725e 
…ison

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Implement WriteToNodeInfo method on Address
3032ed7 
Implement `Address.WriteToNodeInfo` method which sets address of `NodeInfo`
structure. Use it in storage node application.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Don't export L4 protocol constant
3770b7d 
Const is used for internal package needs only.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Use Equal method in IsLocalAddress function
473b05d 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Prevent potential panic in Address.Equal m…
fa07316 
…ethod

Make `Address.Equal` method to accept value instead of pointer in order to
prevent NPE.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Accept value instead of pointer in IsLocalAd…
21d36ad 
…dress

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Remove unused HostAddrFromMultiaddr function.
6cdf2c2 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Reflect all supported formats in AddressFrom…
302da39 
…String docs

Comment that `AddressFromString` function supports host addresses.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Do not return error from `Address.HostAddrSt…
b4eea43 
…ring` method

Panic if internal `manet.DialArgs` call returns error since this is
unexpected according to `AddressFromString` implementation.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Rename Address.HostAddrString method to Host…
1c0ad29 
…Addr

Return tyype is clear from the method's signature and docs, there is no
point in reflecting it in the name.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Remove Address methods used only for testing
b1c47dd 
Remove `Encapsulate`, `Decapsulate` and `IPAddrString` methods of `Address`
since they are used in unit tests only.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Do not use Address.String for address compar…
a461bc6 
…ison

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 16, 2021
[nspcc-dev#607] network: Implement WriteToNodeInfo method on Address
93e033c 
Implement `Address.WriteToNodeInfo` method which sets address of `NodeInfo`
structure. Use it in storage node application.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider mentioned this issue Jun 16, 2021
Merged
@alexvanin
Copy link
Contributor Author

  1. Dedicated Open or Init method

Looks like protocol version handshake becomes handy there.

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 18, 2021
[nspcc-dev#607] network: Do not work with Address pointers
1fd3584 
`network.Address` structure in most cases created once and used read-only.

Replace `AddressFromString` function with `Address.FromString` method with
the same purpose and implementation. Make all libraries to work with value.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 18, 2021
@cthulhu-rider
[#607] network: Don't export L4 protocol constant
b2b33ae 
Const is used for internal package needs only.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 18, 2021
@cthulhu-rider
[#607] network: Use Equal method in IsLocalAddress function
6de0af0 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 18, 2021
@cthulhu-rider
[#607] network: Prevent potential panic in Address.Equal method
fdd123a 
Make `Address.Equal` method to accept value instead of pointer in order to
prevent NPE.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Implement function to stringify AddressGroup
5db7c5c 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Make ClientCache to accept AddressGroup
e11f50e 
Change type of the `ClientCache.Get` method's parameter to `AddressGroup`.
Use `GroupFromAddress` to call the method from the wrappers in order to no
change their interface.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Generalize LocalAddressSource to address group
6e5d7f8 
Make `LocalAddressSource.LocalAddress` method to return `AddressGroup`. Make
`IsLocalAddress` function to accept parameter of type `AddressGroup`. Adopt
the application code with temporary `GroupFromAddress` helper.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] object/put: Make client constructor to work with group address
8972f84 
Make Object Put service to work with `AddressGroup` instead of `Address` in
order to support multiple addresses of the storage node.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] object/get: Make client constructor to work with group address
ad14df0 
Make Object Get service to work with `AddressGroup` instead of `Address` in
order to support multiple addresses of the storage node.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] object/search: Make client constructor to work with group address
d0e48c9 
Make Object Search service to work with `AddressGroup` instead of `Address`
in order to support multiple addresses of the storage node.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] object/head: Make client constructor to work with group address
8ac3c62 
Make Object Head service to work with `AddressGroup` instead of `Address`
in order to support multiple addresses of the storage node.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] placement: Make traverser to return list of address groups
b3dd9a3 
Make placement `Traverser.Next` method to return ``[]network.AddressGroup`
in order to support multiple addresses of the storeage nodes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] placement: Work with AddressGroup
9033cf5 
Make `PlacementBuilder` implementations to work `network.AddressGroup` type.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] ir: Work with AddressGroup instead of single Address
f7b42a1 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] reputation/router: Use public keys as keys to server cache
44a2c81 
In future server info will contain multiple endpoints whose string
representation will be worse suited to the cache key.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] container/announce: Use public keys as keys to server cache
d6bb697 
In future server info will contain multiple endpoints whose string
representation will be worse suited to the cache key.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] reputation,container: Support address groups in ServerInfo
cede2b4 
There is a need to support multiple server endpoints for reputation and
container transmission.

Replace `ServerInfo.Address` getter with `ServerInfo.IterateAddresses`
iterator.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] cmd/node: Make reputationClientConstructor to accept AddressGroup
c444118 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] cmd/node: Empty Control server address as disable
d1eb9c3 
In previous implementation if Control listen endpoint was omitted in config
the gRPC listening endpoint was used instead.

Consider empty address as an option to disable the service.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] cmd/node: Serve gRPC on multiple interfaces
8060735 
Generalize single gRPC interface of the storage node to a group of
interfaces. Each interface calls the same RPC handler.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] cmd/node: Configure group of bootstrap addresses
163c24a 
There is a need to support multiple network addresses of the storage nodes.

Make `BootstrapAddress` to return `network.AddressGroup` (and rename).

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] node/control: Make group address in NodeInfo message
1e52e86 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Sort addresses in AddressGroup.FromIterator method
149367c 
Implement `sort.Interface` interface on `AddressGroup` and perform sorting
in `AddressGroup.FromIterator` method. Addresses with enabled TLS are "less"
in terms of slice position.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Remove no longer used Address.WriteToNodeInfo method
61cc70d 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Make Address.Equal method unexported
b723c92 
The method is used only in the same package.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Remove no longer used Address.AddTLS method
e3eade6 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Remove no longer needed GroupFromAddress function
359bbe3 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Make AddressGroup.WriteToNodeInfo method a function
119031c 
Method implementation doesn't use any private logic.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Add helper function to iterate over all addresses
cbe20a2 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] *: Do not use deprecated elements of code
43eff09 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] network: Support URI address strings
6f861b6 
Make Address.FromString method to parse URI addresses and enable TLS for TLS
schemes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] config/example: Add all formats of node's network addresses
81ddaec 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] services/netmap: Support backward compatibility
f8ee6b1 
Make Netmap service to return single network address on `LocalNodeInfo` RPC
in order to older clients.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Jun 28, 2021
@cthulhu-rider
[#607] services/control: Fix incorrect allocation in NetmapSnapshot
8eadf18 
Fix make with length + subsequent append.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
neofs-storage Storage node application issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multiple addresses of the storage nodes cthulhu-rider/neofs-node
2 participants
@alexvanin @cthulhu-rider