Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node accepts containers with non unique attributes #634

Closed
alexvanin opened this issue Jun 22, 2021 · 1 comment · Fixed by #641
Closed

Node accepts containers with non unique attributes #634

alexvanin opened this issue Jun 22, 2021 · 1 comment · Fixed by #641
Assignees
@carpawell
Labels
bug Something isn't working neofs-ir Inner Ring node application issues
Milestone
v0.22.0 "Muuido"

Comments

@alexvanin
Copy link
Contributor

The same as #633 but for container attributes.

$ ./bin/neofs-cli -r [...] --binary-key [...] container create --policy [...] --attributes Timestamp=0

$ ./bin/neofs-cli -r [...] --binary-key [...] container get --cid [...]
...
attribute: Timestamp=0 (1970-01-01 03:00:00 +0300 MSK)
attribute: Timestamp=1624378604 (2021-06-22 19:16:44 +0300 MSK)
@carpawell carpawell mentioned this issue Jun 23, 2021
Merged
@cthulhu-rider
Copy link
Contributor

Any container attribute should have a non-empty value according to spec. I suggest to add this check too.

@alexvanin alexvanin mentioned this issue Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
bug Something isn't working neofs-ir Inner Ring node application issues
Projects
None yet
Milestone
v0.22.0 "Muuido"
Development

Successfully merging a pull request may close this issue.

Fix/do not accept containers with non unique attributes
3 participants
@alexvanin @carpawell @cthulhu-rider