Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node accepts objects with non unique attributes #633

Closed
alexvanin opened this issue Jun 22, 2021 · 0 comments · Fixed by #642
Closed

Node accepts objects with non unique attributes #633

alexvanin opened this issue Jun 22, 2021 · 0 comments · Fixed by #642
Assignees
@cthulhu-rider
Labels
bug Something isn't working neofs-storage Storage node application issues
Milestone
v0.22.0 "Muuido"

Comments

@alexvanin
Copy link
Contributor

Expected Behavior

Storage nodes do not accept object put requests with non unique attributes (according to specification).

Current Behavior

User can create object with non unique attributes in CLI and storage nodes will successfully proceed it.

Steps to Reproduce (for bugs)

$ ./bin/neofs-cli -r [...] --binary-key [...] object put --cid  [...] \
--file ./LICENSE \
--attributes FileName=ESNECIL
[./LICENSE] Object successfully stored

$ ./bin/neofs-cli -r [...] --binary-key [...] object head --cid [...] --oid [...]
...
Attributes:
  FileName=ESNECIL
  FileName=LICENSE

Your Environment

neofs-node v0.21.0-77-g8fac4acd
@alexvanin alexvanin mentioned this issue Jun 22, 2021
Closed
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 23, 2021
[nspcc-dev#633] object: Prevent duplicate attributes by key
7fa93d3 
Keys of object attributes must be unique according to NeoFS specification.

Make `FormatValidator.Validate` method to return an error if at least one
attribute is duplicated.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 23, 2021
[nspcc-dev#633] object: Disallow empty attribute values
651cff8 
Values of object attributes must not be empty according to NeoFS
specification.

Make `FormatValidator.Validate` method to return an error if at least one
attribute has empty value.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider mentioned this issue Jun 23, 2021
Merged
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 23, 2021
[nspcc-dev#633] object: Disallow empty attribute values
d493cfd 
Values of object attributes must not be empty according to NeoFS
specification.

Make `FormatValidator.Validate` method to return an error if at least one
attribute has empty value.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Jun 23, 2021
[nspcc-dev#633] object: Disallow empty attribute values
a7f1770 
Values of object attributes must not be empty according to NeoFS
specification.

Make `FormatValidator.Validate` method to return an error if at least one
attribute has empty value.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@alexvanin alexvanin mentioned this issue Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
bug Something isn't working neofs-storage Storage node application issues
Projects
None yet
Milestone
v0.22.0 "Muuido"
Development

Successfully merging a pull request may close this issue.

Validate object attributes cthulhu-rider/neofs-node
2 participants
@alexvanin @cthulhu-rider