neofs-cli: fix pass of several object put --attributes flags #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
The `object put` command previously could only retrieve the last `--attributes` parameter if multiple such parameters were provided. Now, the `object put` command correctly parses all `--attributes` values, whether they are provided as comma-separated or single values. Closes #2427. Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
bugfix/2427-cli-object-put-attributes
branch
from
a4b39d4
to
7a79231
Compare
Codecov Report
@@ Coverage Diff @@
## master #2569 +/- ##
==========================================
- Coverage 29.82% 29.81% -0.01%
==========================================
Files 405 405
Lines 30885 30885
==========================================
- Hits 9210 9208 -2
- Misses 20884 20885 +1
- Partials 791 792 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Sep 12, 2023
cthulhu-rider
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
object putcommand previously could only retrieve the last--attributesparameter if multiple such parameters were provided. Now, theobject putcommand correctly parses all--attributesvalues, whether they are provided as comma-separated or single values.Closes #2427.