Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use notary in audit client #658

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

alexvanin
Copy link
Contributor

Audit client should sign all transaction by node's key and do not use multisignature.

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #658 (3fa4016) into master (a2b622d) will not change coverage.
The diff coverage is n/a.

❗ Current head 3fa4016 differs from pull request most recent head 1e4fe0c. Consider uploading reports for the commit 1e4fe0c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #658   +/-   ##
=======================================
  Coverage   43.05%   43.05%           
=======================================
  Files         204      204           
  Lines        8072     8072           
=======================================
  Hits         3475     3475           
  Misses       4256     4256           
  Partials      341      341           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b622d...1e4fe0c. Read the comment docs.

Audit client is used to send audit results and they should be
signed by inner ring node itself on order to be saved in
smart contract.

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
@alexvanin alexvanin merged commit c90f054 into nspcc-dev:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neofs-ir Inner Ring node application issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants