Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout for SDK waiter operations #253

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Add timeout for SDK waiter operations #253

merged 3 commits into from
Oct 24, 2024

Conversation

smallhive
Copy link
Contributor

Closes #246.

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.78571% with 55 lines in your changes missing coverage. Please review.

Project coverage is 23.38%. Comparing base (309119b) to head (53dde94).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
handlers/conv.go 0.00% 39 Missing ⚠️
handlers/containers.go 0.00% 15 Missing ⚠️
handlers/api.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   23.61%   23.38%   -0.23%     
==========================================
  Files          19       20       +1     
  Lines        4731     4781      +50     
==========================================
+ Hits         1117     1118       +1     
- Misses       3455     3504      +49     
  Partials      159      159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roman-khimov
roman-khimov reviewed Oct 23, 2024
View reviewed changes
cmd/neofs-rest-gw/config.go Outdated Show resolved Hide resolved
cmd/neofs-rest-gw/config.go Outdated Show resolved Hide resolved
handlers/containers.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the 246-container-creation-can-hang-indefinitely-in-case-of-underlying-errors branch from 8b9c0d9 to 51917b8 Compare October 23, 2024 07:52
@smallhive smallhive force-pushed the 246-container-creation-can-hang-indefinitely-in-case-of-underlying-errors branch 3 times, most recently from a9d427b to b071a04 Compare October 23, 2024 08:54
@smallhive smallhive force-pushed the 246-container-creation-can-hang-indefinitely-in-case-of-underlying-errors branch from b071a04 to c183286 Compare October 23, 2024 09:28
@roman-khimov roman-khimov mentioned this pull request Oct 23, 2024
Open
@smallhive
handler: Add timeout for SDK waiter operations
edd9220 
Closes #246.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 246-container-creation-can-hang-indefinitely-in-case-of-underlying-errors branch from c183286 to cd5da44 Compare October 23, 2024 10:10
roman-khimov
roman-khimov reviewed Oct 23, 2024
View reviewed changes
handlers/conv.go Outdated Show resolved Hide resolved
handlers/conv.go Outdated Show resolved Hide resolved
handlers/conv.go Show resolved Hide resolved
handlers/conv.go Outdated Show resolved Hide resolved
handlers/conv.go Outdated Show resolved Hide resolved
handlers/conv.go Outdated Show resolved Hide resolved
handlers/conv.go Show resolved Hide resolved
handlers/conv.go Outdated Show resolved Hide resolved
handlers/conv.go Outdated Show resolved Hide resolved
handlers/conv.go Show resolved Hide resolved
@smallhive smallhive force-pushed the 246-container-creation-can-hang-indefinitely-in-case-of-underlying-errors branch from cd5da44 to 9771aa1 Compare October 23, 2024 10:53
@roman-khimov
Copy link
Member

Tests need to be updated.

@smallhive
handler: Return http code according to the NeoFS status
18c2dd3 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive
api: Update API status codes
53dde94 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 246-container-creation-can-hang-indefinitely-in-case-of-underlying-errors branch from 15ab197 to 53dde94 Compare October 23, 2024 11:59
@smallhive
Copy link
Contributor Author

Updated tests

roman-khimov
roman-khimov approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, at this stage it's either one non-universally-valid response or another. Internal server error is a tiny bit safer in general, so let it be this way for now.

@roman-khimov roman-khimov merged commit d6fe7f8 into master Oct 24, 2024
11 of 14 checks passed
@roman-khimov roman-khimov deleted the 246-container-creation-can-hang-indefinitely-in-case-of-underlying-errors branch October 24, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@tatiana-nspcc tatiana-nspcc Awaiting requested review from tatiana-nspcc tatiana-nspcc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container creation can hang indefinitely in case of underlying errors
2 participants
@smallhive @roman-khimov