Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and document object package #226

Open
cthulhu-rider opened this issue Apr 22, 2022 · 1 comment
Open

Refactor and document object package #226

cthulhu-rider opened this issue Apr 22, 2022 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U2 Seriously planned
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

No description provided.

@cthulhu-rider cthulhu-rider added documentation Improvements or additions to documentation enhancement Improving existing functionality refactor labels Apr 22, 2022
@cthulhu-rider cthulhu-rider added this to the v1.0.0 milestone Apr 22, 2022
@cthulhu-rider cthulhu-rider self-assigned this Apr 22, 2022
@cthulhu-rider cthulhu-rider added the U2 Seriously planned label Apr 25, 2022
cthulhu-rider pushed a commit to cthulhu-rider/neofs-sdk-go that referenced this issue Jul 6, 2022
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-sdk-go that referenced this issue Jul 7, 2022
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-sdk-go that referenced this issue Jul 7, 2022
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-sdk-go that referenced this issue Jul 7, 2022
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-sdk-go that referenced this issue Jul 8, 2022
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider removed their assignment Jul 15, 2022
@cthulhu-rider
Copy link
Contributor Author

The implementation hasn't been finalized yet, I'm gonna open draft with recent developments.

@roman-khimov roman-khimov modified the milestones: v1.0.0, v1.0.0-rc9 Apr 26, 2023
@roman-khimov roman-khimov modified the milestones: v1.0.0-rc9, v1.0.0-rc10 May 22, 2023
roman-khimov added a commit that referenced this issue May 24, 2023
If we can return a bool signifying field presence, then it can be used this
way as well. Refs. #226.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@smallhive smallhive self-assigned this Jul 11, 2023
smallhive added a commit that referenced this issue Jul 11, 2023
closes #226

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive added a commit that referenced this issue Jul 13, 2023
closes #226

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive added a commit that referenced this issue Jul 19, 2023
closes #226

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive added a commit that referenced this issue Jul 19, 2023
closes #226

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive reopened this Jul 20, 2023
@roman-khimov roman-khimov removed this from the v1.0.0-rc10 milestone Jul 26, 2023
@roman-khimov roman-khimov added this to the v1.0.0 milestone Jul 26, 2023
cthulhu-rider added a commit that referenced this issue Aug 30, 2023
Previously, package did not provide API to work with search filter
types: group of filters could be composed using clear methods but there
was no ability to access specified information (for example, filter by
object ID).

Newly defined exported constants will allow to switch between
`SearchFilter.Header` results and implement application-specific logic.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Aug 31, 2023
Previously, package did not provide API to work with search filter
types: group of filters could be composed using clear methods but there
was no ability to access specified information (for example, filter by
object ID).

Newly defined exported constants will allow to switch between
`SearchFilter.Header` results and implement application-specific logic.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Aug 31, 2023
Export constants and `SearchFilters` methods related to creation epoch
and payload size.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Aug 31, 2023
Previously, `SearchFilters.AddSplitIDFilter` accepted pointer split ID
instance. This didn't make any sense and, at the same time, could be
unsafe.

Make method to accept `Split` by value. This is a breaking change, but
has meaningful impact and could be fixed easily.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Aug 31, 2023
Object filters may be attributed and non-attribute (for system needs).
The system filter can affect the logic of the application, so it should
be possible to check for its presence.

Add `HasNonAttributeFilter` method to `SearchFilters` that returns true
iff the instance contains non-attribute filter.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Sep 5, 2023
Object filters may be attributed and non-attribute (for system needs).
The system filter can affect the logic of the application, so it should
be possible to check for its presence.

Add `IsNonAttribute` method to `SearchFilter` that returns true iff the
instance is non-attribute.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Sep 5, 2023
Export constants and `SearchFilters` methods related to creation epoch
and payload size.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Sep 5, 2023
Previously, `SearchFilters.AddSplitIDFilter` accepted pointer split ID
instance. This didn't make any sense and, at the same time, could be
unsafe.

Make method to accept `Split` by value. This is a breaking change, but
has meaningful impact and could be fixed easily.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Sep 5, 2023
Object filters may be attributed and non-attribute (for system needs).
The system filter can affect the logic of the application, so it should
be possible to check for its presence.

Add `IsNonAttribute` method to `SearchFilter` that returns true iff the
instance is non-attribute.

Refs #226.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@roman-khimov roman-khimov added I4 No visible changes S3 Minimally significant and removed refactor labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

3 participants