Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set contextCall.err if missed session params #410

Merged
merged 2 commits into from
May 16, 2023
Merged

Set contextCall.err if missed session params #410

merged 2 commits into from
May 16, 2023

Conversation

smallhive
Copy link
Contributor

@smallhive smallhive commented May 11, 2023 •
edited
Loading

close #221

roman-khimov
roman-khimov reviewed May 11, 2023
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK. Can we have a test for it?

@smallhive
Copy link
Contributor Author

Pushed test as separate commit

cthulhu-rider
cthulhu-rider reviewed May 12, 2023
View reviewed changes
client/errors.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the 221-handle-protocol-violation-errors-in-client branch 2 times, most recently from 854da33 to f082067 Compare May 12, 2023 09:59
cthulhu-rider
cthulhu-rider approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, lets resolve minor moments and merge

client/session_test.go Outdated Show resolved Hide resolved
client/errors.go Outdated Show resolved Hide resolved
cthulhu-rider
cthulhu-rider reviewed May 12, 2023
View reviewed changes
client/api.go Outdated Show resolved Hide resolved
notimetoname
notimetoname approved these changes May 12, 2023
View reviewed changes
client/session_test.go Outdated Show resolved Hide resolved
client/errors.go Show resolved Hide resolved
client/session_test.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the 221-handle-protocol-violation-errors-in-client branch from f082067 to 4f82f25 Compare May 15, 2023 03:39
@smallhive
client: Set contextCall.err if missed session params
0c7bfc2 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive
client: Add tests for contextCall.err in session creation
162a15a 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 221-handle-protocol-violation-errors-in-client branch from 4f82f25 to 162a15a Compare May 15, 2023 03:45
@roman-khimov roman-khimov merged commit fec2f06 into master May 16, 2023
@roman-khimov roman-khimov deleted the 221-handle-protocol-violation-errors-in-client branch May 16, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@notimetoname notimetoname notimetoname approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle protocol violation errors in Client
4 participants
@smallhive @roman-khimov @cthulhu-rider @notimetoname