Strip useless res structs #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
cthulhu-rider,
smallhive and
notimetoname
as code owners
cthulhu-rider
approved these changes
May 26, 2023
roman-khimov
force-pushed
the
strip-useless-res-structs
branch
from
5842c00
to
7ed05f9
Compare
There is nothing more there to return. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's the only thing in the ResContainerEACL. Signed-off-by: Roman Khimov <roman@nspcc.ru>
There is nothing else it can return. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's just a list, it doesn't need a wrapper. Signed-off-by: Roman Khimov <roman@nspcc.ru>
The only thing it can return. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It returns a network map, that's it. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Do we have anything else it can return? No. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Not very likely to change with the current NeoFS scheme. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Not the most convenient API type-wise, but that's the way it is. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
strip-useless-res-structs
branch
from
7ed05f9
to
e894db4
Compare
If it's OK, it's just OK. If it's an error, you get some |
smallhive
approved these changes
May 29, 2023
notimetoname
approved these changes
May 29, 2023
There was a problem hiding this comment.
If it's OK, it's just OK.
Agree with you for now but i think it is possible to have some OK results that may have some details (and -- with that PR -- may not be added to any Res* structs anymore) but do not have real examples now.
Just do not see any problems outside of the SDK with getters (they do not add any code lines or make any code much more complex) so i would not spend time on it. But since the work is done, i have no strong cons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got a number of
Res*things with a single member only. They were somewhat useful before #413 (to get request status), but now they provide zero value and just complicate the code using these APIs. Notice also that this makesclientinterface a little close topoolinterface which is nice wrt. #380.