Extended session #447
Merged
Extended session #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallhive
requested review from
roman-khimov,
cthulhu-rider and
notimetoname
as code owners
roman-khimov
reviewed
Jun 9, 2023
| @@ -166,6 +166,11 @@ func (x *Object) Sign(signer neofscrypto.Signer) error { | |||
| return x.sign(signer, x.writeContext) | |||
| } | |||
|
|
|||
| // SignedData returnes actual payload which would be signed, if you call [Object.Sign] method. | |||
| func (x *Object) SignedData() []byte { | |||
There was a problem hiding this comment.
i can offer a pretty indicative scenario for unit test:
- fill token
- call
SignedData - calculate signature manually
- call
Signwith static signer - assert
Verifypasses
session/object.go
Outdated
| @@ -166,6 +166,11 @@ func (x *Object) Sign(signer neofscrypto.Signer) error { | |||
| return x.sign(signer, x.writeContext) | |||
| } | |||
|
|
|||
| // SignedData returnes actual payload which would be signed, if you call [Object.Sign] method. | |||
There was a problem hiding this comment.
Suggested change
| // SignedData returnes actual payload which would be signed, if you call [Object.Sign] method. | |
| // SignedData returns actual payload which would be signed, if you call [Object.Sign] method. |
i'd also paraphrase comment to make it closer to Sign and add cross-reference b/w them: this can make it easier to understand the relationship and differences between the methods
There was a problem hiding this comment.
Fixed, hand trembled
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive
force-pushed
the
extended-session
branch
from
2df93d2
to
72c2f7a
Compare
roman-khimov
approved these changes
Jun 9, 2023
roman-khimov
reviewed
Jun 9, 2023
smallhive
force-pushed
the
extended-session
branch
2 times, most recently
from
86112bb
to
88f556b
Compare
smallhive
force-pushed
the
extended-session
branch
from
88f556b
to
e5c5250
Compare
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive
force-pushed
the
extended-session
branch
from
e5c5250
to
3241296
Compare
roman-khimov
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.