Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slicer upload in some cases #486

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fix slicer upload in some cases #486

merged 1 commit into from
Aug 10, 2023

Conversation

smallhive
Copy link
Contributor

The case when the reader returns io.EOF with the last data chunk. Slicer was closing the writer without payload writing

@smallhive smallhive changed the title Fixed slicer upload in some cases Fix slicer upload in some cases Aug 8, 2023
@smallhive smallhive marked this pull request as ready for review August 8, 2023 10:54
carpawell
carpawell reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. Does it mean that RC10 isn't perfect again in term of Slicer? How did you find it?

Commit's body does not end with a period.

@smallhive
Copy link
Contributor Author

smallhive commented Aug 9, 2023 •
edited
Loading

lol. Does it mean that RC10 isn't perfect again in term of Slicer? How do you found it?

Commit's body does not end with a period.

The period is fixed. I'm updating our gates. Inside HTTP one I updated all upload places to slicer using.
One test started to fail: debug, investigation, found, fixed, profit 😃

RC10 is not perfect, but much closer to it

roman-khimov
roman-khimov requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's disappointing to see this given that exactly this issue had been discussed numerous times in slicer-related PRs. Yet at the same all PRs were reviewed successfully before the respective merges.

Let's hope the new test won't let it happen again.

object/slicer/slicer.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the rc10-fixes branch 2 times, most recently from 53cdd80 to 8adfec8 Compare August 9, 2023 08:42
@smallhive smallhive force-pushed the rc10-fixes branch 3 times, most recently from 25d1ad3 to 1775115 Compare August 9, 2023 11:24
@smallhive
slicer: Fixed object upload in some cases
d61cba5 
The case when the reader returns io.EOF with the last data chunk. Slicer was closing the writer without payload writing.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@cthulhu-rider cthulhu-rider merged commit 4c702aa into master Aug 10, 2023
5 checks passed
@cthulhu-rider cthulhu-rider deleted the rc10-fixes branch August 10, 2023 09:07
@roman-khimov roman-khimov added this to the v1.0.0-rc11 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0-rc11
Development

Successfully merging this pull request may close these issues.
4 participants
@smallhive @roman-khimov @carpawell @cthulhu-rider