Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GETRANGE and GETRANGEHASH have the same requested length #632

Closed
carpawell opened this issue Sep 7, 2023 · 2 comments
Closed

GETRANGE and GETRANGEHASH have the same requested length #632

carpawell opened this issue Sep 7, 2023 · 2 comments
Assignees
Labels
enhancement Improving existing functionality

Comments

@carpawell
Copy link
Member

carpawell commented Sep 7, 2023

Is your feature request related to a problem? Please describe.

I'm always frustrated when I need to debug RANGE and RANGEHASH requests. A node may produce its own request to satisfy a user's one, and it may be a different request kind (e.g. user's RANGEHASH may produce RANGE). Logs do not allow understanding of what exact request happened cause both RANGE and RANGEHASH have the same length (here and here) to the same object usually.

Describe the solution you'd like

If it does not break other tests, I would like to ask to make ranges different for the different requests (e.g. [0:9] and [0:10] or even a rand length for a different test suite in the whole test run). They are often run one by one and network communication becomes a mess (a lot of [0:10] RANGE requests).

Describe alternatives you've considered

Do nothing. I will change those parameters manually every time I run RANGE and RANGEHASH tests then.

Additional context

Sounds strange but would have saved some time in nspcc-dev/neofs-node#2541 debug.

@carpawell carpawell added enhancement Improving existing functionality triage labels Sep 7, 2023
@roman-khimov
Copy link
Member

@evgeniiz321, @vvarg229, feasible?

@vvarg229
Copy link
Collaborator

vvarg229 commented Sep 8, 2023

@evgeniiz321, @vvarg229, feasible?

It seems feasible.

@carpawell carpawell changed the title GETRANGE and GETRANGEHASH have the same hash length GETRANGE and GETRANGEHASH have the same requested length Sep 8, 2023
evgeniiz321 pushed a commit to evgeniiz321/neofs-testcases that referenced this issue Sep 23, 2023
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
evgeniiz321 pushed a commit to evgeniiz321/neofs-testcases that referenced this issue Sep 25, 2023
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
evgeniiz321 pushed a commit to evgeniiz321/neofs-testcases that referenced this issue Sep 25, 2023
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants