Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover account-based EACL targets #838

Closed
roman-khimov opened this issue Aug 18, 2024 · 0 comments · Fixed by #844
Closed

Cover account-based EACL targets #838

roman-khimov opened this issue Aug 18, 2024 · 0 comments · Fixed by #844
Assignees
@evgeniiz321
Labels
feature Completely new functionality I2 Regular impact S4 Routine U2 Seriously planned

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we don't have any tests for cool new features we deliver. nspcc-dev/neofs-api#278 is implemented in the node and it must be tested.

Describe the solution you'd like

Basically, anywhere a key can be used in EACLs an address can be used now as well. So we need to extend our test suite to check for that.
@roman-khimov roman-khimov added U2 Seriously planned S4 Routine I2 Regular impact feature Completely new functionality labels Aug 18, 2024
evgeniiz321 pushed a commit that referenced this issue Aug 23, 2024
tests: add usage of address for tests with eacl
7316457 
closes #838

Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
@evgeniiz321 evgeniiz321 mentioned this issue Aug 23, 2024
Merged
evgeniiz321 pushed a commit that referenced this issue Aug 26, 2024
tests: add usage of address for tests with eacl
efd9e36 
closes #838

Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
roman-khimov added a commit that referenced this issue Aug 29, 2024
@roman-khimov
tests: update existing eacl tests to add usage of an address as a tar…
1df7d85 
…get (#844)

closes #838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgeniiz321 evgeniiz321

Labels
feature Completely new functionality I2 Regular impact S4 Routine U2 Seriously planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: update existing eacl tests to add usage of an address as a target nspcc-dev/neofs-testcases
2 participants
@evgeniiz321 @roman-khimov