Fix load test according to adding a new load node, fixes #544 #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniiz321
requested review from
roman-khimov,
cthulhu-rider and
vvarg229
as code owners
evgeniiz321
force-pushed
the
fix_load_test
branch
from
79f23d6
to
355602e
Compare
evgeniiz321
changed the title
| OBJ_SIZE = os.getenv("OBJ_SIZE", "1000").split(",") | ||
| CONTAINERS_COUNT = os.getenv("CONTAINERS_COUNT", "1").split(",") | ||
| OBJ_SIZE = [int(o) for o in os.getenv("OBJ_SIZE", "1000").split(",")] | ||
| CONTAINERS_COUNT = [int(c) for c in os.getenv("CONTAINERS_COUNT", "1").split(",")] |
There was a problem hiding this comment.
Why a loop here? I'd expect these to be simple numbers.
There was a problem hiding this comment.
It is a little bit strange design, but as I understand, the original intention was to pass test parametrization variables through env vars, but these vars are strings (or more precisely a list of strings, since .split() was used). But these variables are used as ints inside the test, so we need to convert them to ints here. Otherwise inside the test there are numerous TypeError exceptions.
evgeniiz321
force-pushed
the
fix_load_test
branch
from
355602e
to
6f27386
Compare
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
evgeniiz321
force-pushed
the
fix_load_test
branch
from
6f27386
to
769073d
Compare
vvarg229
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.