Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: use common system tests template #881

Merged
merged 1 commit into from
Oct 31, 2024
Merged

.github: use common system tests template #881

merged 1 commit into from
Oct 31, 2024

Conversation

evgeniiz321
Copy link
Contributor

No description provided.

@evgeniiz321 evgeniiz321 self-assigned this Oct 22, 2024
@evgeniiz321 evgeniiz321 marked this pull request as draft October 22, 2024 21:50
@evgeniiz321 evgeniiz321 force-pushed the ezayats/use-common-tests-flow branch 11 times, most recently from 044e5d5 to c3dd0e9 Compare October 24, 2024 01:09
@evgeniiz321 evgeniiz321 mentioned this pull request Oct 24, 2024
Closed
@evgeniiz321 evgeniiz321 force-pushed the ezayats/use-common-tests-flow branch 10 times, most recently from c937326 to b2b356b Compare October 29, 2024 23:34
.github: use common system tests template
a5d3642 
Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
@evgeniiz321 evgeniiz321 marked this pull request as ready for review October 30, 2024 19:52
@roman-khimov
Copy link
Member

Looks like this never ends:

run_system_tests Expected — Waiting for status to be reported

@evgeniiz321
Copy link
Contributor Author

@roman-khimov i assume this is because github is waiting for a single job here, and i added a matrix with macos. Need to update the repo settings

@roman-khimov
Copy link
Member

It allows to add any of subordinate jobs, but also works with top-level.

@roman-khimov
Copy link
Member

Let's check what's gonna happen after the merge.

@roman-khimov roman-khimov merged commit 3a1c805 into master Oct 31, 2024
6 checks passed
@roman-khimov roman-khimov deleted the ezayats/use-common-tests-flow branch October 31, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees

@evgeniiz321 evgeniiz321

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeniiz321 @roman-khimov