-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(beforeAll): fix issue 190 when parent before_all throws #192
Conversation
@amirrajan it seems like changes are needed also w.r.t. Should we just make needed changes in this same PR? EDIT: Also, probably the same thing should then happen for |
…hose from previous hooks
Also, preserve example exception when after throws
…ple exception when after throws
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Purposes of this current PR are, in general: to fail an example when one of the hooks throws unexpectedly, and to avoid executing an example body when one of the beforeAll/before hooks throws. More in detail:
All that, holding for async versions as well.
Initial description
This PR tracks work-in-progress of fixing issue #190 , as well as other possible problems happening when a context-/method-level before or beforeEach or beforeAll throws and subsequent examples should not run and result as failures.