producer: Adds a Ping method in order to validate an nsqd connection #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My only comment is - let's actually make this send a |
|
works for me - do you mind squashing down to one commit? @jehiah any thoughts before we merge? |
|
👍 |
dcarney
force-pushed
the
producer-adds-ping-method
branch
from
8109ec4
to
ccc03f1
Compare
|
@mreiferson Squashed it. Thanks! |
|
hmm, looks like some other recently merged code is conflicting - needs a rebase now, sorry! |
Signed-off-by: dcarney <dcarney@gmail.com>
dcarney
force-pushed
the
producer-adds-ping-method
branch
from
ccc03f1
to
a49cb28
Compare
|
No problem. Rebased it, and also removed an unecessary "fmt" import. |
jehiah
added a commit
that referenced
this pull request
Feb 23, 2015
producer: Adds a Ping method in order to validate an nsqd connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Ping method to the Producer, which allows for testing a Producer's nsqd connection w/o publishing any messages to a topic.
I've found it to be useful for failing fast when configuring Producers that might not Publish immediately (since otherwise, the connections are only made lazily on Publish).
Not thrilled with the method name "Ping", so am totally open to other suggestions.