nsqd: allow disable both HTTP and HTTPS interfaces #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, currently I can achieve a simple lockdown by configuring TLS requirements on all interfaces, but it's a bit annoying to use authentication as a means to protect an unneeded interface vs just disabling it altogether. |
ploxiln
reviewed
Oct 21, 2021
NSQD by defaults opens both the HTTP and well as the HTTPS interface by default (if TLS is set). This is fine as a default behavior, but it's valuable to be able to disable one interface or another to raise the security guarantees (e.g. if TCP is enough, there is no reason to keep 2 more ports open just to have to lock them down in some other way). This commits allows disabling the HTTP interface the same way the HTTPS one could be disabled until now (set it to ""). In addition, it makes a few code cleanups.
ploxiln
reviewed
Oct 22, 2021
| return n.tcpListener.Addr().(*net.TCPAddr) | ||
|
|
There was a problem hiding this comment.
very minor: odd blank line here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSQD by defaults opens both the HTTP and well as the HTTPS interface by default (if TLS is set). This is fine as a default behavior, but it's valuable to be able to disable one interface or another to raise the security guarantees (e.g. if TCP is enough, there is no reason to keep 2 more ports open just to have to lock them down in some other way).
This commits allows disabling the HTTP interface the same way the HTTPS one could be disabled until now (set it to ""). In addition, it makes a few code cleanups.