Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: staticcheck linting cleanup #1427

Merged
merged 20 commits into from
Dec 21, 2022
Merged

*: staticcheck linting cleanup #1427

merged 20 commits into from
Dec 21, 2022

Conversation

mreiferson
Copy link
Member

These seem like mostly good things, should probably run this as part of tests too?

@ploxiln
Copy link
Member

ploxiln commented Oct 19, 2022

looks like i386 test is kinda broken, also go-1.17 staticcheck

@mreiferson
Copy link
Member Author

OK, this should be ready to go now @ploxiln

Copy link
Member

@ploxiln ploxiln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ploxiln
Copy link
Member

ploxiln commented Dec 21, 2022

to summarize what I observed:

  • remove old go-bindata for go < 1.16
  • remove ssl3.0 add tls1.3
  • remove tlsConfig.BuildNameToCertificate() call, deprecated, "NameToCertificate" not needed anymore
  • fix ticker goroutine leak in lookupLoop() ?
  • remove logging from QueryAnyAuthd(), return one big error which is eventually logged in protocol_v2.go
  • remove bits of dead code
  • mechanical cleanups with no functional change (ioutil renames, type switch cleanup ...)

All good stuff 💯

@mreiferson mreiferson merged commit cf12b96 into nsqio:master Dec 21, 2022
@mreiferson mreiferson deleted the cleanup branch December 21, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants