*: increase HTTP client transport timeout #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client is implemented in the authorization of nsqd for requesting it, sometimes my authorization server has unexpected latency increases which I can't control, making the default 2 seconds timeout useless.
|
@alvarolm thanks for the PR. Unfortunately, this timeout in question affects many different HTTP operations. Why don't we make it configurable as a command line flag (default to the current |
mreiferson
changed the title
|
opened #715 to track this, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client is implemented in the authorization of nsqd for requesting it, sometimes my authorization server has unexpected latency increases which I can't control, making the default 2 seconds timeout useless.