Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nx 12.3]: Angular 12 and TypeScript 4.2+ support #267

Closed
NathanWalker opened this issue May 21, 2021 · 2 comments · Fixed by #271
Closed

[Nx 12.3]: Angular 12 and TypeScript 4.2+ support #267

NathanWalker opened this issue May 21, 2021 · 2 comments · Fixed by #271
Assignees

Comments

@NathanWalker
Copy link
Member

Latest Nx 12.3 sets up Angular 12 and TypeScript 4.2.

@NathanWalker NathanWalker self-assigned this May 21, 2021
@NathanWalker NathanWalker changed the title Angular 12 and TypeScript 4.2+ support [Nx 12.3]: Angular 12 and TypeScript 4.2+ support May 21, 2021
@NathanWalker
Copy link
Member Author

Right now with TS 4.2 the following compilation errors occur:

Error: libs/xplat/utils/src/lib/objects.ts:14:35 - error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'unknown'.
  No index signature with a parameter of type 'string' was found on type 'unknown'.

14       if (typeof value !== typeof source[key]) {
                                     ~~~~~~~~~~~


Error: libs/xplat/utils/src/lib/objects.ts:16:23 - error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'unknown'.
  No index signature with a parameter of type 'string' was found on type 'unknown'.

16         result[key] = source[key];
                         ~~~~~~~~~~~


Error: libs/xplat/utils/src/lib/objects.ts:18:40 - error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'unknown'.
  No index signature with a parameter of type 'string' was found on type 'unknown'.

18         result[key] = deepMerge(value, source[key]);
                                          ~~~~~~~~~~~


Error: libs/xplat/utils/src/lib/objects.ts:20:23 - error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'unknown'.
  No index signature with a parameter of type 'string' was found on type 'unknown'.

20         result[key] = source[key];
                         ~~~~~~~~~~~


Error: libs/xplat/utils/src/lib/platform.ts:5:13 - error TS7005: Variable 'NSObject' implicitly has an 'any' type.

5 declare var NSObject, NSString, android, java, window;
              ~~~~~~~~


Error: libs/xplat/utils/src/lib/platform.ts:5:23 - error TS7005: Variable 'NSString' implicitly has an 'any' type.

5 declare var NSObject, NSString, android, java, window;
                        ~~~~~~~~


Error: libs/xplat/utils/src/lib/platform.ts:5:33 - error TS7005: Variable 'android' implicitly has an 'any' type.

5 declare var NSObject, NSString, android, java, window;
                                  ~~~~~~~


Error: libs/xplat/utils/src/lib/platform.ts:5:42 - error TS7005: Variable 'java' implicitly has an 'any' type.

5 declare var NSObject, NSString, android, java, window;39m
                                           ~~~~


Error: libs/xplat/utils/src/lib/platform.ts:5:48 - error TS7005: Variable 'window' implicitly has an 'any' type.

5 declare var NSObject, NSString, android, java, window;

NathanWalker added a commit that referenced this issue May 23, 2021
NathanWalker added a commit that referenced this issue Jun 13, 2021
@alpha2k-io
Copy link

any thoughts on when this would be addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants