Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-157] - correct handling of CallInfo<T> usages #158

Merged
merged 2 commits into from
Jan 31, 2021
Merged

[GH-157] - correct handling of CallInfo<T> usages #158

merged 2 commits into from
Jan 31, 2021

Conversation

tpodolak
Copy link
Member

Closes #157

@coveralls
Copy link

coveralls commented Jan 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 426

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+4.8%) to 95.871%
Files with Coverage Reduction New Missed Lines %
C/projects/nsubstitute-analyzers/src/NSubstitute.Analyzers.Shared/CodeFixProviders/AbstractReEntrantSetupCodeFixProvider.cs 2 96.72%
C/projects/nsubstitute-analyzers/src/NSubstitute.Analyzers.CSharp/DiagnosticAnalyzers/CallInfoCallFinder.cs 18 64.71%
Totals Coverage Status
Change from base Build 424: 4.8%
Covered Lines: 2577
Relevant Lines: 2688
💛 - Coveralls

@tpodolak tpodolak mentioned this pull request Jan 30, 2021
Open
@tpodolak
Copy link
Member Author

@ libs/nsubstitute-latest/NSubstitute.dll this one is built from nsubstitute/NSubstitute#641. Once new version of NSubstitute is released, I will update libs folder

tpodolak
tpodolak commented Jan 30, 2021
View reviewed changes
tests/NSubstitute.Analyzers.Tests.Shared/NSubstituteVersion.cs
{
public enum NSubstituteVersion
{
NSubstitute4_2_2 = 1,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am following similar naming convention as compiler team does in https://github.com/dotnet/roslyn/blob/d0d9a59a9c222e58e679645ff5fdc2c074c8335e/src/Compilers/CSharp/Portable/LanguageVersion.cs#L12
It doesnt look too elegant IMO but I didnt figure out anything better. Any other options?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok 👍

dtchepak
dtchepak approved these changes Jan 31, 2021
View reviewed changes
tests/NSubstitute.Analyzers.Tests.Shared/NSubstituteVersion.cs
{
public enum NSubstituteVersion
{
NSubstitute4_2_2 = 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok 👍

@tpodolak tpodolak merged commit 875e9ec into dev Jan 31, 2021
@tpodolak tpodolak deleted the GH-157-handling-callinfo-of-t branch January 31, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtchepak dtchepak dtchepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle CallInfo<T> from upcoming NSubstitute version
3 participants
@tpodolak @coveralls @dtchepak